Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idm): add subpackage input load support #1581

Closed
wants to merge 14 commits into from

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Feb 1, 2024

Add a subpackage (already idm integrated) to dfn: # mf6 subpackage <subp>

  • where <subp> is, for example, utl-tvk
  • Add another subpackage to the same dfn by adding a new line: # mf6 subpackage <subp2>
  • Any number of subpackage types ok but currently restricted to 1 instance each
  • A new internal tag related to the input filename tag contains the mempath (e.g. when TVK6_FILENAME is defined also expect TVK6_MEMPATH to be defined)

Refactor ascii input loaders:

  • add timeseries to input block definition
  • encapsulate ascii static load in LoadMf6FileType
  • dynamic loader now also controls static load
  • add ascii init interface for dynamic loader types
  • split ascii dynamic list loader implementation into base and derived types

General:

  • use defined constants for string length in input definition types
  • remove package load interface
  • loader variable renaming for consistency
  • rename list and array dynamic loader modules and files

@mjreno mjreno marked this pull request as draft February 1, 2024 19:43
@mjreno mjreno added this to the 6.5.0 milestone Feb 1, 2024
@mjreno mjreno force-pushed the idm_blockfile_load branch from 5229eea to a48c5ec Compare February 7, 2024 12:29
@mjreno mjreno changed the title refactor(idm): preparation for supporting setting input types feat(idm): add subpackage input load support Feb 7, 2024
@mjreno mjreno force-pushed the idm_blockfile_load branch from 1e915b3 to 8753901 Compare February 8, 2024 15:52
@mjreno mjreno force-pushed the idm_blockfile_load branch from 64b2c57 to b562bc7 Compare February 10, 2024 02:37
@mjreno
Copy link
Contributor Author

mjreno commented Feb 12, 2024

Closing temporarily to focus on netcdf PR.

@mjreno mjreno closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant