Promote supports feature to ApplicationRecord

[kbrock]

Most models include SupportsFeatureMixin. This moves up to ApplicationRecord +1/-73

[Fryguy]

@agrare Please also review.

[kbrock]

update:

• rebased
• extracted tools/feature_supports_matrix change (already merged)
• extracted ReadOnlyModels change (closed that PR)

[miq-bot]

Checked commit kbrock@bfbecf9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
64 files checked, 0 offenses detected
Everything looks fine. 🏆

[kbrock]

this is the 1 addition.

Moves this include to ApplicationRecord

[Fryguy]

Most models include SupportsFeatureMixin. This moves up to ApplicationRecord +1/-73

I understand the intent to avoid duplication here, but "most models" isn't really accurate. There are 457 models roughly, and only 73 have this, which means only 16% of models are like this.

One upside to having it in specific models is we can know what models are the things that are "CI"s (i.e. things that we externally manage). That gets me wondering if we should have a CIMixin where we take a lot of these common mixins across CIs, then include that. But overall, I'm not sure that would make any benefit.

I'm not against this PR, but I'm not sure - would like a second opinion from @agrare and/or @jrafanie

[jrafanie]

One upside to having it in specific models is we can know what models are the things that are "CI"s (i.e. things that we externally manage). That gets me wondering if we should have a CIMixin where we take a lot of these common mixins across CIs, then include that. But overall, I'm not sure that would make any benefit.

haha, if you can name what this commonality is, we could probably create it. Ideally, all of these things should be reportable, support features, taggable, etc. We can override in classes that can't do one or more of these things if desired. Not sure how much we want to pull into the common place.

[kbrock]

I think having a plugin that says "I'm a taggable, rbac applyable, data model that is in each provider" may have merit.