Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/json_passing #34

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Fix/json_passing #34

merged 6 commits into from
Sep 3, 2024

Conversation

worksofliam
Copy link
Collaborator

  • Simplifies the SQLJob#send logic by allowing a JSON object to be passed in
  • Fix pool performance test incorrectly testing single job performance
  • Fix broken 'Prepare SQL with Edge Case Inputs' test, which was testing a variable changed by lines of code commented out

@worksofliam
Cleanup multi job pool test
9736a4a 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Remove logs and bad test case
c3311f5 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Less JSON parsing
486018e 
Signed-off-by: worksofliam <[email protected]>
@worksofliam worksofliam linked an issue Sep 3, 2024 that may be closed by this pull request
Pass JSON instead of string #33
Closed
SanjulaGanepola
SanjulaGanepola requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, just some minor comments

src/sqlJob.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
@worksofliam
Copy link
Collaborator Author

Test cases are still passing. Time out happened only in GHA runner:

image

@worksofliam worksofliam merged commit d63780d into main Sep 3, 2024
1 check failed
@worksofliam worksofliam deleted the fix/json_passing branch September 3, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjulaGanepola SanjulaGanepola SanjulaGanepola approved these changes

@jonnyz32 jonnyz32 Awaiting requested review from jonnyz32

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass JSON instead of string
2 participants
@worksofliam @SanjulaGanepola