Allow for immutable debug settings in ddr3_debug #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return from ddr3_tip_print_log() early if we won't print anything anyway. This way the compiler can optimize away the VALIDATE_IF_ACTIVE() calls in the for-loop, so if the SILENT_LIB macro is defined, no code is generated for the rest of the function, which saves some space. Signed-off-by: Marek Behún <[email protected]>
The variables is_default_centralization, is_tune_result and is_bist_reset_bit are never used. Signed-off-by: Marek Behún <[email protected]>
… static The variables is_validate_window_per_if, is_validate_window_per_pup, sweep_cnt and is_run_leveling_sweep_tests are only used if DDR_VIEWER_TOOL macro is defined, so define them only in that case. Make them static since they are only used in ddr3_debug.c. Signed-off-by: Marek Behún <[email protected]>
… size Allow compiling with immutable debug settings: - DEBUG_LEVEL is always set to DEBUG_LEVEL_ERROR - register dumps are disabled This can save around 10 KiB of space in the resulting binary, which is a lot in U-Boot SPL. Signed-off-by: Marek Behún <[email protected]>
elkablo
force-pushed
the
a38x-allow-immutable-debug-settings
branch
from
f1fb686 to
776afb5
Compare
admin-turris
pushed a commit
to turris-cz/u-boot
that referenced
this pull request
Jul 2, 2024
Backport the option to compile with immutable debug settings also to the old implementation of the DDR3 training code. The original PR for mv-ddr-marvell can be seen at MarvellEmbeddedProcessors/mv-ddr-marvell#45 Signed-off-by: Marek Behún <[email protected]>
trini
pushed a commit
to trini/u-boot
that referenced
this pull request
Jul 8, 2024
Backport the option to compile with immutable debug settings also to the old implementation of the DDR3 training code. The original PR for mv-ddr-marvell can be seen at MarvellEmbeddedProcessors/mv-ddr-marvell#45 Signed-off-by: Marek Behún <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 3 commits cleanup the code a little.
The 4th commit creates a new compile-time option,
CONFIG_DDR_IMMUTABLE_DEBUG_SETTINGS, which, when enabled, makes it impossible to select the debug level dynamically, and instead all debug levels are set to the defaultDEBUG_LEVEL_ERROR. Also register dumps are always disabled.Because the code is mainly used in U-Boot and in U-Boot the DDR3 training debug level can only be changed by editing the sources and compiling, enabling this option has no functional change for the default settings.
This reduces the size of the binary by around 10 KiB, which is a lot in U-Boot SPL.