Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.11 #1362

Merged
merged 9 commits into from
Nov 11, 2022
Merged

Support Python 3.11 #1362

merged 9 commits into from
Nov 11, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 19, 2022

Closes #1361.

@ml-evs ml-evs added the blocked For issues/PRs that are blocked by required changes/clarifications to the specification. label Oct 19, 2022
@ml-evs ml-evs changed the title Add support for Python 3.11 Support Python 3.11 Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1362 (e0d9174) into master (e9ffd76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files          72       72           
  Lines        4369     4369           
=======================================
  Hits         3996     3996           
  Misses        373      373           
Flag Coverage Δ
project 91.46% <ø> (ø)
validator 91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JPBergsma
Copy link
Contributor

You may have to use 3.11-dev instead of 3.11.0-rc.2

setup.py Outdated
@@ -98,7 +97,7 @@
"Topic :: Database :: Database Engines/Servers",
"Topic :: Database :: Front-Ends",
],
python_requires=">=3.8,<3.11",
python_requires=">=3.8,<3.12",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python_requires=">=3.8,<3.12",
python_requires=">=3.8",

I think we should actually open this requirement up completely; this upgrade was fairly painless, beyond pinning one particular sub-dep, and as we are a hybrid library/application we don't want to the hold up for other packages!

@ml-evs ml-evs added enhancement New feature or request and removed blocked For issues/PRs that are blocked by required changes/clarifications to the specification. labels Nov 11, 2022
@ml-evs ml-evs marked this pull request as ready for review November 11, 2022 10:55
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ml-evs ml-evs merged commit 2394476 into master Nov 11, 2022
@ml-evs ml-evs deleted the ml-evs/py311_ci branch November 11, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11
2 participants