fix: addresses off by one issue with dialog filter for skills, addres… #5950
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5950 +/- ##
=========================================
Coverage 10.28% 10.29%
- Complexity 6123 6130 +7
=========================================
Files 1039 1039
Lines 139328 139358 +30
Branches 20632 20638 +6
=========================================
+ Hits 14331 14342 +11
- Misses 123589 123605 +16
- Partials 1408 1411 +3 ☔ View full report in Codecov by Sentry. |
| @@ -394,7 +394,7 @@ public boolean include(Entry<? extends PersonnelTableModel, ? extends Integer> e | |||
| return false; | |||
| } else if ((null != primaryRole) && (p.getPrimaryRole() != primaryRole)) { | |||
| return false; | |||
| } else if ((null != expLevel) && (p.getExperienceLevel(campaign, false) != expLevel)) { | |||
| } else if ((null != expLevel) && (p.getExperienceLevel(campaign, false)+1 != expLevel)) { | |||
There was a problem hiding this comment.
I'm not sure about this fix. I think this should be held back until we have time to do a more thorough investigation. 50.03 launches in a few hours, so that likely won't be in time for launch.
|
Marking this for New Dev Cycle as I think we need to take a proper look at this rather than putting in what feels like a ductile fix - a fix that likely works, but not one resolving the underlying issue. Skills being Ultra Green at different skill levels is, however, working as intended. As different skills can have skill levels set to different points. One skill might be Green at level 3, while another might be Green at level 1 - for example. |
|
Hacks are not allowed. We want proper fixes. Sorry. We appreciate the desire to fix, but this wont be accepted as skills have different growth paths. |
…ses issue: #5922
I'm not sure if this is the correct way to address this issue. I'm a bit confused as to the consistency surrounding the skill levels. In some places, ultra green starts at 0 and in some places it starts with 1. This just hacks in a +1.