Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addresses off by one issue with dialog filter for skills, addres… #5950

Closed
wants to merge 1 commit into from
Closed

fix: addresses off by one issue with dialog filter for skills, addres… #5950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MekHQ/src/mekhq/gui/dialog/BatchXPDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ public boolean include(Entry<? extends PersonnelTableModel, ? extends Integer> e
return false;
} else if ((null != primaryRole) && (p.getPrimaryRole() != primaryRole)) {
return false;
} else if ((null != expLevel) && (p.getExperienceLevel(campaign, false) != expLevel)) {
} else if ((null != expLevel) && (p.getExperienceLevel(campaign, false)+1 != expLevel)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this fix. I think this should be held back until we have time to do a more thorough investigation. 50.03 launches in a few hours, so that likely won't be in time for launch.

return false;
} else if (onlyOfficers && !p.getRank().isOfficer()) {
return false;
Expand Down