-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove bridge src token list from controller state #29492
Merged
+109
−492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelae
force-pushed
the
mms1825-rm-bridge-src-token-list
branch
2 times, most recently
from
January 13, 2025 22:30
7584fa1
to
6e1f281
Compare
micaelae
force-pushed
the
mms1825-rm-bridge-src-token-list
branch
from
January 14, 2025 01:02
2acbd2a
to
a5192d5
Compare
Builds ready [2acbd2a]
Page Load Metrics (1708 ± 64 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
ghgoodreau
approved these changes
Jan 14, 2025
Builds ready [226b4c5]
Page Load Metrics (1841 ± 73 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
jclancy93
approved these changes
Jan 15, 2025
darkwing
approved these changes
Jan 16, 2025
metamaskbot
added
the
release-12.12.0
Issue or pull request that will be included in release 12.12.0
label
Jan 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reduces data stored in the BridgeController by removing stored bridge-specific token lists, and reusing token data from the assets controllers instead.
Changes
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1825
Depends on https://github.com/consensys-vertical-apps/va-mmcx-bridge-api/pull/136
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist