Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retain src input amount after switching tokens #29709

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jan 14, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1798

Manual testing steps

  1. Load bridge page
  2. Select amount, src token and dest token
  3. Click token switch button to swap src and dest selections
  4. Verify that src amount is preserved

Screenshots/Recordings

Before

Amount is cleared

After

Amount is preserved

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae force-pushed the mms1798-preserve-amount-value branch from cb0b6ae to 1922b06 Compare January 14, 2025 19:24
@metamaskbot
Copy link
Collaborator

Builds ready [1922b06]
Page Load Metrics (1633 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34917971565294141
domContentLoaded1415178416099043
load1419180016339445
domInteractive19193423818
backgroundConnect56223199
firstReactRender1688452613
getState44913147
initialActions01000
loadScripts1054137112117536
setupStore6529105
uiStartup16022214190815072
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -38 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review January 15, 2025 01:23
@micaelae micaelae requested a review from a team as a code owner January 15, 2025 01:23
@micaelae micaelae force-pushed the mms1798-preserve-amount-value branch from 1922b06 to bd2ddf2 Compare January 16, 2025 23:33
@micaelae micaelae enabled auto-merge January 16, 2025 23:34
@metamaskbot
Copy link
Collaborator

Builds ready [bd2ddf2]
Page Load Metrics (1727 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint134429161725342164
domContentLoaded133628751700336161
load135229131727342164
domInteractive23212544220
backgroundConnect97428209
firstReactRender1576352311
getState56913178
initialActions01000
loadScripts93722811253290139
setupStore667212110
uiStartup151232321962375180
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -38 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 2751a0d Jan 17, 2025
72 checks passed
@micaelae micaelae deleted the mms1798-preserve-amount-value branch January 17, 2025 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants