-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: Use API to properly tag prereleases #246
Conversation
f061b90
to
2333ada
Compare
fb85fc2
to
75f75fb
Compare
@Mic92 I've added the atom feed as a fallback now and also added support for |
The test failure is from |
1ad7fc4
to
9a70e95
Compare
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2c1937e |
Could you cut a new release? I'd really like to get rid of the r-ryantm spam |
Release is out. |
There is one issue with this. Some projects don't have github releases i.e. https://github.com/mongodb/mongo/ On the other hand tags work: https://api.github.com/repos/mongodb/mongo/tags?per_page=1000 |
Yes, ran into this issue for protonvpn-gui and dependencies today: https://api.github.com/repos/ProtonVPN/proton-vpn-gtk-app/releases does not contain the tags but the old atom-feed did. Can we have a switch for the new behavior and keep the old default for now? |
I can add a second fallback in case list of releases is empty. I think that is a better approach |
This breaks so many packages that have used GitHub releases in the past but only push tags these days. The audible-cli package should be changed to use |
#221 related pr, closed because it would have been a regression |
I think this is not enough. Some packages, such as lspce, have a non-empty release list but there are newer tags which are not included in the release list. |
Partial revert in #274 |
r-ryantm keeps opening pull requests for a github package where the latest release is a prerelease
https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aclosed+audible-cli
The reason is that
nix-updated
uses the RSS feed to get the releases which does not distinguish between a release and a prerelease. Using the github API fixes that.