Feat add erc20 wrapping delegate #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vminkov
requested changes
Dec 13, 2022
vminkov
requested changes
Dec 15, 2022
There was a problem hiding this comment.
looks mostly good, only the storage layout order should be adhered to
I am only hesitant if we need to have the ability to change/update the wrapping instance - we could add that fn if needed, but there shouldn't be such need if we have enough confidence in the ERC20Wrapper contract's security
vminkov
requested changes
Dec 16, 2022
vminkov
reviewed
Dec 16, 2022
vminkov
reviewed
Dec 16, 2022
vminkov
approved these changes
Dec 16, 2022
…o feat/add-erc20wrappingdelegator
vminkov
requested changes
Dec 20, 2022
|
I will make some minor changes and then merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
High-level change(s) description - from the user's perspective
Related Issue(s)
Fixes
Related pull request(s)