Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way of working for leaving laptops unattended #258

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

laurensWe
Copy link
Member

Description

Please include a summary of the changes and the related issue.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilizes.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@laurensWe laurensWe requested a review from a team as a code owner October 24, 2024 11:02
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the assumptions and consequences in this ADR

@anneschuth anneschuth changed the title Add ADR for leaving laptops unmanaged Add ADR for leaving laptops unattended Oct 24, 2024
anneschuth
anneschuth previously approved these changes Oct 24, 2024
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

anneschuth
anneschuth previously approved these changes Oct 24, 2024
ravimeijerrig
ravimeijerrig previously approved these changes Oct 24, 2024
Copy link
Contributor

@ravimeijerrig ravimeijerrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/adrs/0017-laptop-security.md Outdated Show resolved Hide resolved
docs/adrs/0017-laptop-security.md Outdated Show resolved Hide resolved
docs/adrs/0017-laptop-security.md Outdated Show resolved Hide resolved
@berrydenhartog
Copy link
Member

Does not feel like an Architectural Decision record to me...

@anneschuth
Copy link
Member

Does not feel like an Architectural Decision record to me...

I believe this is about choosing social architecture over technical controls to enforce security - that's a system-wide architectural pattern worth documenting, even if the implementation involves cookies ;)

Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small minor detail

docs/adrs/0017-laptop-security.md Outdated Show resolved Hide resolved
@berrydenhartog
Copy link
Member

I do not agree to this ADR and will not participate. Feels like a sorority rule/club.

@berrydenhartog
Copy link
Member

@anneschuth , i do not think the way you and i look at ADRs are the same. In many documents written by thought leaders in software engineering it is very clear that an architectural decision records is related to software architecture and documenting matter-full decisions on the things that matter in a software project. I have never seen anyone talk about social architecture and ADRs. do you have any material to support your ideas?

I love this talk from martin folwer on software architecture: https://www.youtube.com/watch?v=DngAZyWMGR0

@laurensWe
Copy link
Member Author

Will be migrated to way-of-working

@laurensWe laurensWe requested review from ChristopherSpelt and ravimeijerrig and removed request for ravimeijerrig October 29, 2024 09:51
@ravimeijerrig ravimeijerrig changed the title Add ADR for leaving laptops unattended Add way of working for leaving laptops unattended Oct 31, 2024
@anneschuth
Copy link
Member

@anneschuth , i do not think the way you and i look at ADRs are the same. In many documents written by thought leaders in software engineering it is very clear that an architectural decision records is related to software architecture and documenting matter-full decisions on the things that matter in a software project. I have never seen anyone talk about social architecture and ADRs. do you have any material to support your ideas?

I love this talk from martin folwer on software architecture: https://www.youtube.com/watch?v=DngAZyWMGR0

Yeah, you're probably right. I'm more or less treating ADRs as if they're RFCs (which they are not, RFCs are broader). I guess in my mind this was on the border, but I get your point of view as well.

Good that it is moving to WoW!

@laurensWe laurensWe merged commit 465676e into main Dec 2, 2024
4 checks passed
@laurensWe laurensWe deleted the feature/adr-security branch December 2, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

7 participants