forked from necojackarc/auto-request-review
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Issues/Timelines API to retrieve all previously requested reviewers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warwolt
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor thoughts but otherwise I think this looks good to me (but I'm also not a GHA hacker so, would do good for others to give reviews as well)
Volgar
reviewed
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR (#3) attempted to skip re-assigning aliases that had previously been assigned to the pull request.
Based on the github documentation, the previous API will only return current aliases that have been requested for review. This breaks two scenarios:
This PR moves to using the timelineevents API which will give us every alias that has been requested regardless of their current status. Because the
timeline
can have a lot of events and the REST version doesn't allow us to filter, I opted to both swap to using GraphQL version and added pagination support..The final change is to Unit Tests where we pull in rewire in order to mock private methods of our
github.js
file. Primarily due to issues with mocking a constructor now that we had to change the instantiation of octokit.