Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Issues/Timelines API to retrieve all previously requested reviewers #4

Merged
merged 51 commits into from
Feb 28, 2024
Merged

Use Issues/Timelines API to retrieve all previously requested reviewers #4

merged 51 commits into from
Feb 28, 2024

Commits on Feb 23, 2024

  1. rename method to indicate all reviewers

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b2a3c0c View commit details
    Browse the repository at this point in the history

  2. move fetch reviewers api to timeline api

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6890af3 View commit details
    Browse the repository at this point in the history

  3. npm run build

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2534cc6 View commit details
    Browse the repository at this point in the history

  4. check if network call succeeds

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3cd2079 View commit details
    Browse the repository at this point in the history

  5. typo

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2fd9c03 View commit details
    Browse the repository at this point in the history

  6. try naming parameter

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    bd96f0e View commit details
    Browse the repository at this point in the history

  7. try not using a string

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c03a6f4 View commit details
    Browse the repository at this point in the history

  8. ugh

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    169f7f2 View commit details
    Browse the repository at this point in the history

  9. try direct api

    @jamoor-moj
    jamoor-moj committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f37708b View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. add log

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    dce8ac5 View commit details
    Browse the repository at this point in the history

  2. check strings

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    93e2cd5 View commit details
    Browse the repository at this point in the history

  3. compare

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    d2fbf5f View commit details
    Browse the repository at this point in the history

  4. print paginate

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    b9a34bd View commit details
    Browse the repository at this point in the history

  5. try double quotes

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    82f310a View commit details
    Browse the repository at this point in the history

  6. ?

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    ace28eb View commit details
    Browse the repository at this point in the history

  7. try request

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    79d9ecf View commit details
    Browse the repository at this point in the history

  8. :)

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    09740a9 View commit details
    Browse the repository at this point in the history

  9. redo

    @jamoor-moj
    jamoor-moj committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c4b91e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. npm install graphql pagination, try all 3 requests

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    500af05 View commit details
    Browse the repository at this point in the history

  2. i have no idea what im doing :)

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    239a388 View commit details
    Browse the repository at this point in the history

  3. more confusion

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    acc270a View commit details
    Browse the repository at this point in the history

  4. yolo

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a31c0ea View commit details
    Browse the repository at this point in the history

  5. ahh

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d4e5971 View commit details
    Browse the repository at this point in the history

  6. all the attempts

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2eaf6a4 View commit details
    Browse the repository at this point in the history

  7. stay on target

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5b4dfe3 View commit details
    Browse the repository at this point in the history

  8. use default graphql call

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8d0f8d4 View commit details
    Browse the repository at this point in the history

  9. try removing '

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f8c4ae4 View commit details
    Browse the repository at this point in the history

  10. typo :)

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    4f06859 View commit details
    Browse the repository at this point in the history

  11. validate pagination

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    abb18e1 View commit details
    Browse the repository at this point in the history

  12. try again

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    06194e9 View commit details
    Browse the repository at this point in the history

  13. add comment links, rename cursor from docs

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    e393b3d View commit details
    Browse the repository at this point in the history

  14. force lots of data we dont care about

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    626ba82 View commit details
    Browse the repository at this point in the history

  15. check optional chaining

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    06acfe2 View commit details
    Browse the repository at this point in the history

  16. parse out name

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b6ce89b View commit details
    Browse the repository at this point in the history

  17. i suck

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2207a80 View commit details
    Browse the repository at this point in the history

  18. add results to reviewers, test optional chaining

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0512145 View commit details
    Browse the repository at this point in the history

  19. fallback to empty string

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d393737 View commit details
    Browse the repository at this point in the history

  20. monkaS

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5618931 View commit details
    Browse the repository at this point in the history

  21. add logs

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7c3abbb View commit details
    Browse the repository at this point in the history

  22. the debug logs win again

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f98700b View commit details
    Browse the repository at this point in the history

  23. clean up parsing

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    dd42169 View commit details
    Browse the repository at this point in the history

  24. more cleanup

    @jamoor-moj
    jamoor-moj committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d5802d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. fix npm version issues

    @jamoor-moj
    jamoor-moj committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f875be6 View commit details
    Browse the repository at this point in the history

  2. move test infrastructure to use rewire to override private variables

    @jamoor-moj
    jamoor-moj committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    30cc4a6 View commit details
    Browse the repository at this point in the history

  3. convert test mocks to new format, add unexpected response tests, fix … 

    …fallback logic
    @jamoor-moj
    jamoor-moj committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    21eb725 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. use foreach loop, rename for PR feedback

    @jamoor-moj
    jamoor-moj committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1308306 View commit details
    Browse the repository at this point in the history

  2. add support for approved users that may not have been requested for r… 

    …eview
    @jamoor-moj
    jamoor-moj committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3d59ef3 View commit details
    Browse the repository at this point in the history

  3. convert from set to array

    @jamoor-moj
    jamoor-moj committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    34ec10d View commit details
    Browse the repository at this point in the history

  4. confused

    @jamoor-moj
    jamoor-moj committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    80870bd View commit details
    Browse the repository at this point in the history

  5. Revert "confused" 

    This reverts commit 80870bd.
    @jamoor-moj
    jamoor-moj committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    446b519 View commit details
    Browse the repository at this point in the history

  6. print / variable name nits

    @jamoor-moj
    jamoor-moj committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e751e6c View commit details
    Browse the repository at this point in the history