Antag Rep #1212
Merged
Antag Rep #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code/__HELPERS/_lists.dm
Outdated
| if(list_to_pick.len) | ||
| var/picked = pick_weight(list_to_pick) | ||
| list_to_pick[picked] = null | ||
| list_to_pick.Remove(picked) |
There was a problem hiding this comment.
This and the line above can just be replaced with -=, unless a num value needs some kind of ref clearing for some reason
|
|
||
| /datum/preferences/proc/return_default_antag_rep() | ||
| if(!parent) | ||
| return 10 |
There was a problem hiding this comment.
These return values should also use defines, also if these have the same value then I think it could just use || and or ?.
| @@ -45,3 +45,6 @@ | |||
| ) | |||
| ///amount of lootboxes owned | |||
| var/lootboxes_owned = 0 | |||
|
|
|||
| ///our current antag rep (base is 10) | |||
| var/antag_rep = 10 | |||
There was a problem hiding this comment.
This should be a define
| return GLOB.blessed_ckeys[parent.ckey][2] | ||
|
|
||
| /datum/preferences/proc/return_rep_multiplier() | ||
| if(!parent) |
There was a problem hiding this comment.
same here for the duplicate values
monkestation/code/modules/storytellers/antag_rep/helper_procs.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/storytellers/converted_events/_base_event.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/storytellers/converted_events/_base_event.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/storytellers/converted_events/_base_event.dm
Outdated
Show resolved
Hide resolved
| antag_rep = default | ||
| save_preferences() | ||
|
|
||
| /datum/preferences/proc/return_default_antag_rep() |
There was a problem hiding this comment.
come to think of it I think this proc could be refactored to just return a var instead all these exact values
This was referenced Feb 16, 2024
Closed
Closed
Closed
This was referenced Feb 19, 2024
This was referenced Feb 19, 2024
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
add: antag rep, for every roll you go without being antag your odds increase, resetting when you become and antag, passing a roll won't remove your rep
/:cl: