Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Cloner Won't Spit out a Body if it has no Ghost #1956

Merged
merged 3 commits into from
May 31, 2024

Conversation

Uristthedorf
Copy link
Contributor

@Uristthedorf Uristthedorf commented May 22, 2024

About The Pull Request

If a clone from an experimental cloner has no mind, when the clone is finished it will be deleted.

Why It's Good For The Game

Experimental cloner on autoprocess can create a large amount of rejected clones with no mind, creating a mess. This PR solves this by deleting the unwanted clones.

Changelog

🆑
qol: Clones made in an experimental cloner that don't have a mind will be deleted.
/:cl:

@Uristthedorf Uristthedorf marked this pull request as draft May 22, 2024 04:42
@Uristthedorf
Copy link
Contributor Author

Ook likes the idea of clones having a 5% chance of being evil when no ghost takes them, but I don't know how to code that so oh well.

@Uristthedorf
Copy link
Contributor Author

Uristthedorf commented May 22, 2024

Maybe later I'll make an evil clone thing but for now this QOL change is enough.

@Uristthedorf Uristthedorf marked this pull request as ready for review May 22, 2024 22:33
@wraith-54321
Copy link
Collaborator

why does this need so much code to do this?

@Uristthedorf
Copy link
Contributor Author

why does this need so much code to do this?

I wanted to have a check at the end of a cloning cycle to see if there was a mind inside the clone. go_out() is at the end of the cycle, so I decided to get that from the normal cloner and use a modified version of it that checks for a mind, I don't think I can just erase the rest of go_out() for the experimental cloner because that's a needed part of the cloning stuff. I had tried putting the mind check in growclone() but that was early enough in the cloning cycle that bodies would spawn and get deleted rather fast, both making an odd noise and spamming ghosts.

I could try adding a function to cloning.dm that does nothing, and then using it in the experimental cloner to check for a mind.

@wraith-54321
Copy link
Collaborator

yeah do that, copy pastes like this are bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants