[PORT] Adds a unit test for typepaths that are required to be mapped onto each station map #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
commented
Jun 21, 2024
| @@ -12,6 +12,9 @@ | |||
| }, | |||
| "space_ruin_levels": 0, | |||
| "space_empty_levels": 2, | |||
| "ignored_unit_tests": [ | |||
There was a problem hiding this comment.
added northstar to the ignore list bc it's not in rotation and i don't think anyone pays attention to it while PRing lol
this can ofc be removed if we ever actually start using northstar
…apped onto each station map (#74985) Inspired by #74967 and #68459 , and the fact that Tramstation regresses very often - Adds a unit test, `required_map_items`, which ensures that certain typepaths which should definitely be mapped onto every map is mapped onto every map It can also be used to ensure that items which should not be mapped in multiple times are not, among other things. I included a few examples - - Min 1, max inf of each head of staff stamps - Min 1, max 1 departmental order consoles - Min 1, max inf comms console - Min 1, max 1 Pun Pun - Min 1, max 1 Poly - Min 1, max 1 Ian If, in the future, a mapper decides they (for some reason) do not want a certain previously-required item on their map, the test can be adjusted such that it allows excluding or something, but currently it should be for items which require conscious thought about. I attempted to make this a linter before realizing two things 1. Someone might make a spawner which spawns the items, or they might get placed in a locker, in any case this accounts for everything on init 2. Linters run on every map, non-station maps included So I went with a test Why is it always the CMO stamp? Not necessary (unless I find a map missing something, then this will be updated)
|
this is so fucking blessed |
Absolucy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of tgstation/tgstation#74985
Adds a unit test,
required_map_items, which ensures that certain typepaths which should definitely be mapped onto every map is mapped onto every mapIt can also be used to ensure that items which should not be mapped in multiple times are not, among other things.
I included a few examples -
If, in the future, a mapper decides they (for some reason) do not want a certain previously-required item on their map, the test can be adjusted such that it allows excluding or something, but currently it should be for items which require conscious thought about.
I attempted to make this a linter before realizing two things
So I went with a test
Why It's Good For The Game
Why is it always the CMO stamp?
Changelog
🆑
fix: TramStation now has the CMO's stamp properly mapped in.
fix: KiloStation now has the CMO's stamp, prefilled cassette rack, and the curator's radio "properly" mapped in.
add: Mapped ATMs and holomaps into Blueshift.
/:cl: