Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOUNTY] [PORT] Nova's pixelshieft #2801

Closed
wants to merge 13 commits into from

Conversation

Marabout2
Copy link
Contributor

@Marabout2 Marabout2 commented Aug 1, 2024

About The Pull Request

Porting Nova's pixelshift

Why It's Good For The Game

Ask the person who did the bounty

Changelog

Adapted the code to make the port work

🆑
add: Pixelshifting with the default keybind being B
code: Added in /module/ a pixel_shift folder with all the stuff in it
🆑

@dwasint
Copy link
Collaborator

dwasint commented Aug 2, 2024

since this is from nova you should modularize the changes so defines in the monkestation defines folder and the rest of it into a folder named pixelshift with a readme

@Marabout2
Copy link
Contributor Author

I don't really understand, I've already put the defines in the monkestation defines folders while also putting the rest of the stuff in the correct stuff, can I get more explanation for my smooth brain ? (I genuinely don't understand what do you wish for me to do)

@KnigTheThrasher
Copy link
Contributor

I don't really understand, I've already put the defines in the monkestation defines folders while also putting the rest of the stuff in the correct stuff, can I get more explanation for my smooth brain ? (I genuinely don't understand what do you wish for me to do)

put the modular stuff in monkestation folder

@Marabout2
Copy link
Contributor Author

Well, the modular stuff should be done, I believe so atleast

@KnigTheThrasher
Copy link
Contributor

Well, the modular stuff should be done, I believe so atleast

no, your code still isn't in the monkestation folder

@Odairu
Copy link
Contributor

Odairu commented Aug 5, 2024

image
the first one should go in
code/__DEFINES/~monkestation/keybinding.dm
and for the second one make a new file in the
code/__DEFINES/~monkestation folder and put them in there.

as for
image
put that in a new file under monkestation/code/datums/keybinding

@Odairu
Copy link
Contributor

Odairu commented Aug 5, 2024

I made something similar for items, if you want an example of how I did the modularization for the COMSIGs and Keybind https://github.com/Monkestation/Monkestation2.0/pull/2850/files

@Absolucy
Copy link
Member

Should I close this, now that #2850 is merged?

@Absolucy Absolucy closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants