-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOUNTY] [PORT] Nova's pixelshieft #2801
Conversation
since this is from nova you should modularize the changes so defines in the monkestation defines folder and the rest of it into a folder named pixelshift with a readme |
I don't really understand, I've already put the defines in the monkestation defines folders while also putting the rest of the stuff in the correct stuff, can I get more explanation for my smooth brain ? (I genuinely don't understand what do you wish for me to do) |
put the modular stuff in monkestation folder |
Well, the modular stuff should be done, I believe so atleast |
no, your code still isn't in the monkestation folder |
I made something similar for items, if you want an example of how I did the modularization for the COMSIGs and Keybind https://github.com/Monkestation/Monkestation2.0/pull/2850/files |
Should I close this, now that #2850 is merged? |
About The Pull Request
Porting Nova's pixelshift
Why It's Good For The Game
Ask the person who did the bounty
Changelog
Adapted the code to make the port work
🆑
add: Pixelshifting with the default keybind being B
code: Added in /module/ a pixel_shift folder with all the stuff in it
🆑