Event Groups: morbillion anomalies begone! #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkestation/code/modules/storytellers/converted_events/event_overrides.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/storytellers/converted_events/event_overrides.dm
Outdated
Show resolved
Hide resolved
monkestation/code/modules/storytellers/converted_events/event_overrides.dm
Show resolved
Hide resolved
This was referenced Aug 20, 2024
This was referenced Aug 20, 2024
Closed
This was referenced Aug 21, 2024
Closed
Closed
This was referenced Aug 25, 2024
Closed
Closed
Closed
This was referenced Aug 27, 2024
Open
Closed
This was referenced Aug 28, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This adds "event groups", to replace shared occurrence types. Changelog should explain it well enough, but I also tried to document the code a bit.
Why It's Good For The Game
This situation sucks:
ATTENTION
ATTENTION
ATTENTION
ATTENTION
[in the span of 15 seconds: comms is now out, there is a flux and dimensional anomaly, and meteors are incoming]
Changelog
🆑
add: Added an "event groups" mechanic to event/storyteller logic.
add: Events in the same group will all have a shared cooldown, and some groups have a set maximum amount of times they can run.
add: The more times events in a group have been ran, the cooldown will become more biased towards the upper bound of the possible cooldown time with each run.
add: As an example, the "Anomalies" event group has a cooldown between 10 to 25 minutes.
/:cl: