Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces rigged storyteller with automatic transfer votes #3278

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Sep 8, 2024

About The Pull Request

This reverts the "rigged storyteller" that goes nuts after the 85 minute mark, with an automatic crew transfer vote - starting at the 90 minute mark, and re-voting every 30 mins if it doesn't pass.

In addition, if the transfer vote doesn't pass, the storyteller's point gain multiplier for the roleset track will be increased, which will allow the storyteller to naturally inject more ghost roles and such, to keep things interesting.

Players cannot start transfer votes on their own - only admins or the automatic subsystem can.

The timing of the votes can be fully configured via the TRANSFER_VOTE_TIME and SUBSEQUENT_TRANSFER_VOTE_TIME config options. The default is 90 minutes initially, with a subsequent vote every 30 mins after.

Also, I added examine block borders to the vote start/result messages.

Closes #3091

Why It's Good For The Game

Allows longer rounds to still be reasonable if the players actually desire it, while still increasing opportunities for ghosts to join back into the round.

Changelog

🆑
balance: The storyteller now actually still continues to matter after the 85 minute mark.
add: Added an automatic crew transfer vote - which will first start at the 90 minute mark, and repeat every 30 minutes if it doesn't pass. If it passes, the shuttle will be called (and cannot be recalled). Players cannot manually start transfer votes - only admins or the server itself can.
qol: Made the vote start/end messages in chat look better and easier to see.
/:cl:

@dwasint
Copy link
Collaborator

dwasint commented Sep 8, 2024

we already have a subsystem dedicated to this, and wasn't being used because when I added it at the request of people it was complained about until it was disabled.

@Absolucy
Copy link
Member Author

gonna merge this bc it's basically a perma-testmerge right now anyways, balancing/tweaking it can be a future PR.

@Absolucy Absolucy merged commit 1860e5b into Monkestation:master Sep 22, 2024
22 checks passed
@Absolucy Absolucy deleted the transfer-vote branch September 22, 2024 00:14
github-actions bot added a commit that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants