-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces rigged storyteller with automatic transfer votes #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already have a subsystem dedicated to this, and wasn't being used because when I added it at the request of people it was complained about until it was disabled. |
This was referenced Sep 8, 2024
This was referenced Sep 11, 2024
Open
This was referenced Sep 18, 2024
Closed
Closed
This was referenced Sep 20, 2024
gonna merge this bc it's basically a perma-testmerge right now anyways, balancing/tweaking it can be a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This reverts the "rigged storyteller" that goes nuts after the 85 minute mark, with an automatic crew transfer vote - starting at the 90 minute mark, and re-voting every 30 mins if it doesn't pass.
In addition, if the transfer vote doesn't pass, the storyteller's point gain multiplier for the roleset track will be increased, which will allow the storyteller to naturally inject more ghost roles and such, to keep things interesting.
Players cannot start transfer votes on their own - only admins or the automatic subsystem can.
The timing of the votes can be fully configured via the
TRANSFER_VOTE_TIME
andSUBSEQUENT_TRANSFER_VOTE_TIME
config options. The default is 90 minutes initially, with a subsequent vote every 30 mins after.Also, I added examine block borders to the vote start/result messages.
Closes #3091
Why It's Good For The Game
Allows longer rounds to still be reasonable if the players actually desire it, while still increasing opportunities for ghosts to join back into the round.
Changelog
🆑
balance: The storyteller now actually still continues to matter after the 85 minute mark.
add: Added an automatic crew transfer vote - which will first start at the 90 minute mark, and repeat every 30 minutes if it doesn't pass. If it passes, the shuttle will be called (and cannot be recalled). Players cannot manually start transfer votes - only admins or the server itself can.
qol: Made the vote start/end messages in chat look better and easier to see.
/:cl: