Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports syndicate horses, and fixes space movement bug, adds syndicate body armor, clarification #3646

Merged
merged 14 commits into from
Oct 24, 2024

Conversation

Shoddd
Copy link
Collaborator

@Shoddd Shoddd commented Oct 3, 2024

About The Pull Request

Ports tgstation/tgstation#78874
which adds syndicate horses and 18 TC outlaw kit to nukie uplink containing a 357 cowboy clothes and one syndicate horse

Fixes all mobs being ridable through space by porting tgstation/tgstation#83345

Adds Syndicate body armor that is 4 TC and has 2 small item slots (anything that fits in pockets) and the same armor stats as infiltrator suit but only covers chest and groinsyndicate body armor

Updates chameleon kit description to mention multi tool locking

Why It's Good For The Game

The outlaw cowboy kit allows for a ton of new gimmicks and style. Gives a new mount for people to play with and use in different places which we dont have many currently.

All mobs being able to fly through space is a bug and takes away specialness of things like space carps.

Syndicate body armor is buyable by tots and nukies. Currently nukies only form of armor is modsuits, modsuits don't allow for a lot of gimmicks, style, or just using some items like northstar gloves. They either go modsuit or no armor. This armor has chameleon settings so it can let them dress up without worrying about being 2 tapped by a shotgun and may encourage many more people to do gimmicks and RP.
In tots case they also don't have access to any great armor outside of modsuits, most the stuff they can buy on station is pretty bad. This acts as a inbetween a full modsuit and stealing body armor.
dreamseeker_1fkeI59VzY

Chameleon clothes being able to be locked by multitool makes them MUCH more useable but isn't mentioned anywhere but in code.

Changelog

🆑
add: Nukies can now buy the outlaw kit for 18 TC
add: Syndicate horses, obtainable from outlaw kit
add: Syndicate body armor, obtainable for 4 TC from any uplink
qol: mentions you can lock chameleon clothes with multitool
fix: All mountable mobs can no longer ride through space
/:cl:

@Shoddd
Copy link
Collaborator Author

Shoddd commented Oct 3, 2024

only failing to fix conflicts with test merge

@Shoddd Shoddd marked this pull request as draft October 4, 2024 03:42
@Shoddd Shoddd marked this pull request as ready for review October 4, 2024 04:14
@Shoddd Shoddd marked this pull request as draft October 6, 2024 17:37
@Shoddd
Copy link
Collaborator Author

Shoddd commented Oct 6, 2024

closing this until borbops temperature PR is merged

@Shoddd Shoddd closed this Oct 6, 2024
@Shoddd Shoddd reopened this Oct 14, 2024
@Shoddd Shoddd marked this pull request as ready for review October 14, 2024 00:08
@Shoddd Shoddd marked this pull request as draft October 14, 2024 17:05
@Shoddd Shoddd changed the title Adjust ridable mob movespeed, ports syndicate horses, and fixes space movement bug Adjust ridable mob movespeed, ports syndicate horses, and fixes space movement bug, adds syndicate body armor Oct 14, 2024
@Shoddd Shoddd changed the title Adjust ridable mob movespeed, ports syndicate horses, and fixes space movement bug, adds syndicate body armor Adjust ridable mob movespeed, ports syndicate horses, and fixes space movement bug, adds syndicate body armor, clarification Oct 14, 2024
@Shoddd Shoddd marked this pull request as ready for review October 14, 2024 21:27
code/datums/components/riding/riding_mob.dm Outdated Show resolved Hide resolved
code/modules/uplink/uplink_items/stealthy_tools.dm Outdated Show resolved Hide resolved
@Shoddd Shoddd changed the title Adjust ridable mob movespeed, ports syndicate horses, and fixes space movement bug, adds syndicate body armor, clarification ports syndicate horses, and fixes space movement bug, adds syndicate body armor, clarification Oct 18, 2024
@Loiosh42
Copy link
Contributor

Horse ops....

@Shoddd Shoddd requested a review from Absolucy October 18, 2024 18:52
@Absolucy Absolucy merged commit 1ae1266 into Monkestation:master Oct 24, 2024
22 of 23 checks passed
github-actions bot added a commit that referenced this pull request Oct 24, 2024
@Shoddd Shoddd deleted the giddyup branch October 24, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants