The monster hunter blood vial is now just a status effect instead of a weird status effect + reagent combination #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2024
Closed
Kitsunemitsu
added
Minor
Refactor/Rework
This was referenced Dec 18, 2024
Closed
Closed
Absolucy
force-pushed
the
mh-blood-thingy-fixup
branch
2 times, most recently
from
8a9dd32 to
1762f48
Compare
|
need to do more testing and tweaking to ensure that the effects are close enough or the same as previously |
…a weird status effect + reagent combination
Absolucy
force-pushed
the
mh-blood-thingy-fixup
branch
from
1762f48 to
f91595d
Compare
This was referenced Dec 20, 2024
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
…a weird status effect + reagent combination (Monkestation#4578)
Gw0sty
pushed a commit
to Gw0sty/Monkestation2.0
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
this changes the MH blood vial to just be implemented in
/datum/status_effect/cursed_blood, rather than a weird split between/datum/status_effect/cursed_bloodand/datum/reagent/medicine/blood_viali've moved the status effect to the priority processing speed, as it's something where delayed ticks can be the difference between life and death.
also gave it an icon, albeit just the blooddrunk icon, and slightly cleaned up the code overall.
Why It's Good For The Game
it being a reagent kinda fucks over IPC monster hunters and such, and it's kinda dumb anyways that it was both a status effect AND a reagent. also it was possible to be allergic to the blood vial, which was... unfortunate if someone with allergies actually rolled MH.
so let's just make it a status effect.
Changelog
🆑
refactor: The effect from a monster hunter's blood vial is now just a status effect, rather than a weird combination between a status effect and a reagent.
/:cl: