Fix auto move cancel action when not triggered #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-also make PeriodicActionComponent null safe
|
Hooray Jenkins reported success with all tests good! |
rzats
added
Topic: Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Short follow up to #2557.
The current implementation will cancel the periodic action each time any periodic action is triggered.
The PeriodicActionComponent is not null safe on removal (note the null -> long autoboxing), which causes periodic NPEs.
How to test
Enable any module that triggers periodic action, like the portals module (place one portal block in the world, then watch the log).