Jukebox betterment #412
Merged
Jukebox betterment #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it fully respects deaf people. (#81135) - Jukebox is refactored into a datum that the rave visor and the jukebox uses. - Jukebox UI is now typescript. - How the Jukebox delivers sound to players has been rewritten. - Now it adjusts the sound's position in accordance to where the listener is. - This implementation was loosely inspired by that done by Baystation half a decade ago, so kudos to them. - Additionally, being deafened will temporarily mute the jukebox. - And sorry, in refactoring this I snuck in one tiny feature. - You can now toggle looping on Jukeboxes to play the song foreeeverrrrr. It sounds wayyyyyy better. Overhead isn't even that bad, though it could be tested on a live server to make sure.
MrMelbert
added
the
Cherry Picked
|
We love hearing Second Reality with positional audio! also the PR in question because melbert lazy: tgstation/tgstation#81135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the TG PR for more information.