chore(deny): fix advisories #20220
Merged
chore(deny): fix advisories #20220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting on dependent packages to update.
## Description `derivative` is unmaintained. Switch existing uses to use `derive_more` instead, which is an existing dependency that has all the necessary features. This also required bumping `derive_more` to `1.0.0`, which introduced some small breaking changes, and means that we are pulling in two versions of `derive_more` due to transitive dependency constraints, but in this case, it should be okay because we are mainly using this dep for its proc macros, and one hopes that eventually the transitive deps will upgrade to `1.x` as well. ## Test plan CI
## Description We are not using this dependency and `cargo deny` includes an advisory that it has been rolled into `opentelemetry`, which this change silences. ## Test plan CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
approved these changes
Nov 11, 2024
bmwill
approved these changes
Nov 11, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address
cargo denychecks for:instantis unmaintained -- it is only used by transitive dependencies -- added toignorelist.backoff, but unclear if that will get picked up asbackoffalso seems unmaintained: refactor(instant): Make instant an optional dependency ihrwein/backoff#70opentelemetry_apiis folded intoopentelemetry-- we don't use the former, we can just get rid of the dependency.derivativeis unmaintained.derive_more(which needed to be bumped).deny.tomlignorelist to let dependencies upgrade in their own time.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.