Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deny): fix advisories #20220

Merged
merged 3 commits into from
Nov 11, 2024
Merged

chore(deny): fix advisories #20220

merged 3 commits into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. chore(deny): allowlist advisories 

    Waiting on dependent packages to update.
    @amnn
    amnn committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bac3eec View commit details
    Browse the repository at this point in the history

  2. chore(deny): remove direct dep on derivative 

    ## Description

`derivative` is unmaintained. Switch existing uses to use `derive_more`
instead, which is an existing dependency that has all the necessary
features.

This also required bumping `derive_more` to `1.0.0`, which introduced
some small breaking changes, and means that we are pulling in two
versions of `derive_more` due to transitive dependency constraints, but
in this case, it should be okay because we are mainly using this dep for
its proc macros, and one hopes that eventually the transitive deps will
upgrade to `1.x` as well.

## Test plan

CI
    @amnn
    amnn committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    796292f View commit details
    Browse the repository at this point in the history

  3. chore(deny): Remove dependency on opentelemetry_api 

    ## Description

We are not using this dependency and `cargo deny` includes an advisory
that it has been rolled into `opentelemetry`, which this change
silences.

## Test plan

CI
    @amnn
    amnn committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ab7e647 View commit details
    Browse the repository at this point in the history