UFS-dev PR#183 #1094
Merged
UFS-dev PR#183 #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/CLM/clm_lake.f90 and remove OPTIONAL keyword from Fortran code to fix intel 19 runtime issues
grantfirl
requested review from
Qingfu-Liu,
dustinswales,
barlage,
cenlinhe,
tanyasmirnova,
SamuelTrahanNOAA,
JongilHan66,
gthompsnWRF,
RuiyuSun,
AndersJensen-NOAA and
lisa-bengtsson
as code owners
grantfirl
requested review from
rhaesung,
mkavulich and
climbfuji
and removed request for
barlage,
Qingfu-Liu,
gthompsnWRF,
tanyasmirnova,
SamuelTrahanNOAA,
RuiyuSun,
cenlinhe,
JongilHan66,
lisa-bengtsson and
AndersJensen-NOAA
climbfuji
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Approving my own PRs to ufs-dev (ignoring the changes from the other PRs that are included here and that are reviewed and merged separately).
It is worth noting that the original PR description doesn't capture all the changes of ufs-dev PR #183, since during the testing two more commits were added:
Bug fixes in Thompson MP and CLM Lake found by Dusan
Use assumed-size arrays in lakeini routine in physics/SFC_Models/Lake…
This was referenced Oct 17, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to ufs-community#183