Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appended National Science Foundation wherever required #283

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

adityakiran1423
Copy link
Collaborator

@adityakiran1423 adityakiran1423 commented Nov 25, 2024

Only one mentioning of National Center for Atmospheric Research which I could find (README.md).
There is no mentioning of "National Center for Atmospheric Research" in copyright headers in source code and no mentioning in the docs folder as well

In docs/source/conf.py l17 and l18:

copyright = f'2024-{datetime.datetime.now().year}, NCAR/UCAR'
author = 'NCAR/UCAR'

Do changes need to be made in these lines as well? No other mentioning in acronyms either.
Closes issue #279

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (8bd10e1) to head (604e3a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   79.90%   79.90%           
=======================================
  Files          12       12           
  Lines         821      821           
=======================================
  Hits          656      656           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@K20shores K20shores linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost! We have a reference to ncar in our docs that still needs the NSF bit

copyright = f'2024-{datetime.datetime.now().year}, NCAR/UCAR'
author = 'NCAR/UCAR'

@K20shores K20shores merged commit e2fcc2d into main Nov 27, 2024
4 checks passed
@K20shores K20shores deleted the nsf-ncar branch November 27, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references to NCAR to NSF NCAR
3 participants