Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting runtimes for meeting #147

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Olender
Copy link
Collaborator

@Olender Olender commented Mar 5, 2025

This branch was initially created for testing before the Total technical meeting. However, several issues were identified and have now been addressed in this update:

  • Ensured source=None is set before calling _map_sources_and_receivers().
  • Removed the sudo section from the new workflow.
  • Added a 1% threshold for Codecov test coverage changes.

@Olender Olender requested review from SouzaEM and ruansava March 5, 2025 10:10
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (6d958e6) to head (f5ceafb).

Files with missing lines Patch % Lines
spyro/meshing/meshing_functions.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   84.97%   84.89%   -0.09%     
==========================================
  Files          60       60              
  Lines        3953     3958       +5     
==========================================
+ Hits         3359     3360       +1     
- Misses        594      598       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant