Getting runtimes for meeting

.github/workflows/build_firedrake_main.yml

@@ -18,13 +18,6 @@ jobs:
 
       - uses: actions/checkout@v4
 
-      - name: Install system dependencies
-        run: |
-          git clone https://github.com/firedrakeproject/firedrake.git
-          sudo apt-get update
-          sudo apt-get -y install \
-            $(python3 ./firedrake/scripts/firedrake-configure --show-system-packages)
-
       - name: Install PETSc
         run: |
           git clone https://github.com/firedrakeproject/petsc.git

codecov.yml

@@ -0,0 +1,8 @@
+coverage:
+  status:
+    project:
+      default:
+        target: auto
+        # adjust accordingly based on how flaky your tests are
+        # this allows a 1% drop from the previous base commit coverage
+        threshold: 1%

setup.cfg

@@ -7,14 +7,6 @@ exclude = .git,__pycache__
 [coverage:run]
 omit=*/site-packages/*,*/test/*,*/.eggs/*,/home/alexandre/firedrake/*
 
-[codecov]
-precision = 2
-range = 70...100
-comment_layout = diff, files
-comment_behavior = default
-require_changes = false
-threshold = 1
-
 [pep8]
 ignore = E501,E226,E731,E741,W503
 exclude = .git,__pycache__

spyro/meshing/meshing_functions.py

@@ -274,9 +274,7 @@
         """
         Creates a mesh based on Firedrake meshing utilities.
         """
-        if self.dx is None:
-            raise ValueError("dx is not set")
-        elif self.dimension == 2:
+        if self.dimension == 2:
             return self.create_firedrake_2D_mesh()
         elif self.dimension == 3:
             return self.create_firedrake_3D_mesh()
@@ -287,6 +285,8 @@
         """
         Creates a 2D mesh based on Firedrake meshing utilities.
         """
+        if self.dx is None and self.cpw is not None:
+            self.dx = calculate_edge_length(self.cpw, self.minimum_velocity, self.source_frequency)
         if self.abc_pad:
             nx = int((self.length_x + 2*self.abc_pad) / self.dx)
             nz = int((self.length_z + self.abc_pad) / self.dx)
@@ -482,6 +482,14 @@
         # raise NotImplementedError("Not implemented yet")
 
 
+def calculate_edge_length(cpw, minimum_velocity, frequency):
+    v_min = minimum_velocity
+
+    lbda_min = v_min/frequency
+
+    edge_length = lbda_min/cpw
+    return edge_length
+
 # def create_firedrake_3D_mesh_based_on_parameters(dx, cell_type):
 #     nx = int(self.length_x / dx)
 #     nz = int(self.length_z / dx)

spyro/solvers/wave.py

@@ -76,6 +76,7 @@ def __init__(self, dictionary=None, comm=None):
 
         self.mesh = self.get_mesh()
         self.c = None
+        self.sources = None
         if self.mesh is not None:
             self._build_function_space()
             self._map_sources_and_receivers()
@@ -88,7 +89,6 @@ def __init__(self, dictionary=None, comm=None):
         # Expression to define sources through UFL (less efficient)
         self.source_expression = None
         # Object for efficient application of sources
-        self.sources = None
 
         self.field_logger = FieldLogger(self.comm, self.input_dictionary["visualization"])
         self.field_logger.add_field("forward", self.get_function_name(),