-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Don't ask again" User Experience improvements across DevHub #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersalomonsen
changed the title
test setup for discussions
"Don't ask again" User Experience improvements across DevHUB
Mar 14, 2024
petersalomonsen
changed the title
"Don't ask again" User Experience improvements across DevHUB
"Don't ask again" User Experience improvements across DevHub
Mar 14, 2024
playwright vscode extension
improve by adding more focus on elements, scrolling into view, and waiting one second before pressing submit
parse JSON of modal before comparing with expected
… post with canceling the tx
…DevHub/neardevhub-bos into feat/689-dont-ask-again-ux
…. update to latest playwright to use page.unrouteAll function.
…on't expect loading indicator to still be visible after transaction toast disabled
petersalomonsen
requested review from
Megha-Dev-19,
Tguntenaar and
ailisp
as code owners
March 21, 2024 06:29
Megha-Dev-19
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @petersalomonsen for adding the tests for proposals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #687, but for whole DevHub.
What is covered here is improving of the "Don't ask again experience for":
SubscribedFeed.jsx
component ( a copy of the original feed component ), which use the subscription parameter for receiving the feed index contents. This will automatically refresh every 5 seconds. (see notes over the video below about this)This PR also reduce flaky tests by
await
before expects, increasing test timeoutsPreview environment
https://near.social/devgovgigs.petersalomonsen.near/widget/app
Videos and issues
The video below shows the user experience when creating a discussion. Note the delay between that the spinner disappears and the discussion appear. The challenge here is that there is that Social.index cache invalidation is hard (haven't found a way yet) to trigger, and so I've configured the feed to subscribe every fifth second. The ignoreCache option of Social.index does unfortunately only work once per page session ( needs a reload ).
creatediscussion.mp4
Proposals:
proposal.mp4
Part of issue #689