Fix uninitialized values in cs_profile when iv == -3
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lharris4
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
This should be correct. Thank you for submitting a fix so quickly.
@laurenchilutti can we bring this back into GitLab? Thanks.
This follows the suggestion of Lucas Harris in NOAA-GFDL#301 for the fix.
spencerkclark
force-pushed
the
fix-uninitialized-field
branch
from
71eee1f to
8f9bece
Compare
|
@lharris4 thanks for quickly providing the suggestion for the fix! FYI my force push was only to update the commit message to indicate all values of |
Apologies for potentially interfering with the CI with this rapid re-push. |
bensonr
approved these changes
Oct 24, 2023
|
@spencerkclark No problem, thank you for taking care of this. |
spencerkclark
added a commit
to ai2cm/SHiELD-wrapper
that referenced
this pull request
Nov 1, 2023
This PR updates the dycore, physics, and driver NOAA-GFDL submodules in this repo to their latest `main` branches. Now that - NOAA-GFDL/SHiELD_physics#31 - NOAA-GFDL/atmos_drivers#31 - NOAA-GFDL/atmos_drivers#30 - NOAA-GFDL/GFDL_atmos_cubed_sphere#302 have been merged, all the required features in SHiELD are in place to bring SHiELD-wrapper up-to-par with fv3gfs-wrapper. Note that NOAA-GFDL/SHiELD_physics#31 made changes to the long names of some of the diagnostics output in our regression test, which required a checksum update. I have also taken the liberty to remove the disclaimer from the README that states that changes to SHiELD are required to bring SHiELD-wrapper up-to-par with FV3GFS. That is no longer a limiting factor, and those remaining features are implemented in open PRs in this repo.
spencerkclark
added a commit
to spencerkclark/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the suggestion from @lharris4 in #301 (comment), this assigns values to
gam(i,km)consistent with the interior of the column wheniv == -3incs_profile. It should be expected to change answers for non-hydrostatic simulations wherefv_core_nml.kord_wz < -7.Fixes #301
How Has This Been Tested?
This has not been tested for scientific correctness, though I have tested that the change proposed here addresses the non-reproducibility issue identified in #301. I now get bitwise-identical results every time I run the model in this configuration.
Checklist:
Please check all whether they apply or not