add container buildscript creation for createDockerfile
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhd789
reviewed
Nov 27, 2024
| else: | ||
| sys.exit() | ||
| # create build script for container | ||
| dockerBuild.createBuildScript(containerBuild, containerRun) |
There was a problem hiding this comment.
Hmm ok, I thought this looked ok but for some reason I'm seeing this when testing:
AttributeError: 'container' object has no attribute 'createBuildScript'
There was a problem hiding this comment.
WAIT, I think I just forgot to install the recent changes in my conda environment
singhd789
reviewed
Nov 27, 2024
|
|
||
| # run the script if option is given | ||
| if run: | ||
| subprocess.run(args=[dockerBuild.userScriptPath], check=True) |
There was a problem hiding this comment.
Just need to import subprocess on the top!
singhd789
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates the
createDockerfilefremake subcommand to create a short container build script instead of running commands directly.I also added another level of indents so it'll only create the build script/run if the
if iscontainerconditional is true like the commands above it. I think it needs the commands above it for the build script to work properly, but I don't really know how multiplatform builds work so let me know if it should be moved back.This needs #271 in first, which adds the same functionality to run-fremake with container builds.
Issue ticket number and link (if applicable)
Checklist before requesting a review