generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Nexus Writer for t-route formatted QLAT outputs #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
…n t-route compatible form
program--
force-pushed
the
605-qlat-outputs
branch
from
September 19, 2023 14:54
40a02a7
to
336cb9a
Compare
mattw-nws
reviewed
Sep 21, 2023
|
||
//Still hacking nexus output for the moment | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah.. can we just delete this block now?
Open
Probably replaced by #744 |
@hellkite500 @donaldwj does it seem reasonable to close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
ngen::utils::nexus_writer
base class withngen::utils::nexus_csv_writer
andngen::utils::nexus_netcdf_writer
derived classes. This implements part 1 of #605.See NOAA-OWP/t-route#636 for the output schema. Output file names are formatted as:
{%Y%m%d%H%M}NEXOUT.{nc|csv}
, based on t-route's parsing logic.Usage
The following modifications should be made before using this:
ngen
, export theNGEN_QLAT_FORMAT
environment variable to be eithernetcdf
orcsv
.forcing_parameters.qlat_file_pattern_filter
is set to*NEXOUT.csv
or*NEXOUT.nc
, depending on the format you output.output_root
in your realization config so that the outputs are aggregated under a single directory.forcing_parameters.qlat_input_folder
points to the same location as your realization config'soutput_root
, if set.Additions
ngen::utils::nexus_writer
ngen::utils::nexus_csv_writer
ngen::utils::nexus_netcdf_writer
NGEN_QLAT_FORMAT=netcdf
will output NetCDF files, or otherwise CSV files.Changes
src/NGen.cpp
to include the logic for usingngen::utils::nexus_writer
.src/NGen.cpp
to prevent destruction ofnexus_collection
, since the flowpath/segment IDs are needed for method calls tonexus_writer
.Notes
NGEN_QLAT_FORMAT
is set to "NetCDF" at run-time, then astd::runtime_error
will be thrown when any ofnexus_netcdf_writer
's methods are called.Testing
Todos
t-route
PR (waiting on inland hydraulics)Checklist
Testing checklist (automated report can be put here)
Target Environment support