Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi layer 2 #618

Closed
wants to merge 48 commits into from
Closed

Multi layer 2 #618

wants to merge 48 commits into from

Conversation

donaldwj
Copy link
Contributor

[Short description explaining the high-level reason for the pull request]

Additions

Add one missing commit from the multi-layer development branch

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

donaldwj and others added 30 commits July 6, 2023 20:46
@donaldwj @mattw-nws
Add trival multi layer hydrofabric sample.
bc9884d
@donaldwj @mattw-nws
Added Multlevel hydrofabric sample file.
0b5acf6
@donaldwj @mattw-nws
Added level variable to HY_Catchment. Added function to get and set c…
ae1f8a9 
…atchment level. Added constant variables to mark predefined catchment level values.
@donaldwj @mattw-nws
Add missing config file for a multilevel configuration testing.
32bb806
@donaldwj @mattw-nws
Updated level variables in multilevel hydrofabric test to match docum…
88434af 
…entation.
@donaldwj @mattw-nws
Update non mpi code to handle hydro fabric multiple levels. Fix bug w…
758898f 
…here level was not a string.
@donaldwj @mattw-nws
Add support for hydrofabric levels.
6f6413e
@donaldwj @mattw-nws
Added runtime loop based on levels.
6eb6398
@donaldwj @mattw-nws
saving for merge
f212291
@donaldwj @mattw-nws
Fix for error in rebase.
c813e1e
@donaldwj @mattw-nws
Fix missing variable in HY_Features.hpp
79665b9
@donaldwj @mattw-nws
added test file using google test replacing stand alone test.
b82da39
@donaldwj @mattw-nws
fix parsing of layer data from the formulation config file.
29216b7
@donaldwj @mattw-nws
Update test code for multilayer.
dbf2b27
@donaldwj @mattw-nws
Multilayer test added to CMake.
652e5ec
@donaldwj @mattw-nws
Add datastructures for storing layer meta data and add those structur…
922e3c5 
…es to the formulation manager.
@donaldwj @mattw-nws
Inital multi time step muti level time loop
42e0a5e
@mattw-nws
Simulation_Time methods useful for multilayer
bb95a5a
@donaldwj @mattw-nws
Change get_properties() of the FeatureBase class to return const or n…
f1d0628 
…ormal references to avoid copies of maps
@donaldwj @mattw-nws
add an internal map to the network class to track layer association.
605810a
@donaldwj @mattw-nws
Add support for filtering a network based on level.
e1881ef
@donaldwj @mattw-nws
Create inital skelton of layer class.
6c623cb
@donaldwj @mattw-nws
add <string> to simulation_time.hpp to fix VSCode issue
01539c5
@donaldwj @mattw-nws
Add missing changes to Layer.hpp
563fa87
@donaldwj @mattw-nws
moved logic to run catchments into layer class
726fc4e
@donaldwj @mattw-nws
remove code that is no longer needed
7b1ed93
@donaldwj @mattw-nws
Fix typos
2d067fa
@donaldwj @mattw-nws
update layer control for better depnd btwn layers
062586d
@donaldwj @mattw-nws
Add command to advance the current time stored in a layer.
2867f03
@donaldwj @mattw-nws
add current_timestep_epoch_time to layers
1c892bf
donaldwj and others added 18 commits July 6, 2023 20:46
@donaldwj @mattw-nws
commit changes to simulation time object to allow current time update.
e119816
@donaldwj @mattw-nws
Fix to missing changes on pervious commit.
3f0299e
@donaldwj @mattw-nws
Updates to fix testing on Multilayer
b16bb3b
@donaldwj @mattw-nws
Add current_time_index to SurfaceLayer to
dc7b05f 
improve readability
@donaldwj @mattw-nws
Added more documentation to main time loop.
e7bcd87 
Fixed change to .gitignore
@donaldwj @mattw-nws
Fix to HY_Features constructor
9c00898 
set of levels is now correctly updated.
@donaldwj @mattw-nws
Add defualt layer creation to formulation manager
96fdee2
@donaldwj @mattw-nws
fix bad units on defualt layer
c9fe2d6
@donaldwj @mattw-nws
Correct units string for default layer.
1cb583e
@donaldwj @mattw-nws
Fix merge error in HH_Features_MPI.hpp
52d02b8
@mattw-nws
Required fixes for serial build
acdd022
@donaldwj
Create HY_Catchments with level metadata in single processor mode.
b64af75
@donaldwj
Change HY_Features constructor to use the link hydrofabric version th…
22a7c93 
…at works with levels.
@donaldwj
Resolving issues from pr review.
ee1577e
@donaldwj
Correct typedef to ussing change that was not finished.
6803778
@donaldwj
Correct primary time loop time objects was not being advanced.
5953311
@donaldwj
More corrections to time object advancment.
b25be4b
@donaldwj
Remove debuging code.
49f559a
@mattw-nws mattw-nws force-pushed the multi_level_hydrofabric branch 3 times, most recently from 34e95c0 to fc67105 Compare August 23, 2023 21:13
@mattw-nws
Copy link
Contributor

Closing in favor of #615

@mattw-nws mattw-nws closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donaldwj @mattw-nws