Code

Multi layer 2#618

Code

Closed

donaldwj wants to merge 48 commits intoNOAA-OWP:multi_level_hydrofabricNOAA-OWP/ngen:multi_level_hydrofabricfrom donaldwj:multi_layer_2donaldwj/ngen:multi_layer_2Copy head branch name to clipboard

+1,110-145

Commits

Commits on Jul 6, 2023

• Add trival multi layer hydrofabric sample.

  

  donaldwj

  authored and

  mattw-nws

  committed
  bc9884d

  Copy full SHA for bc9884d

• Added Multlevel hydrofabric sample file.

  

  donaldwj

  authored and

  mattw-nws

  committed
  0b5acf6

  Copy full SHA for 0b5acf6

• Added level variable to HY_Catchment. Added function to get and set catchment level. Added constant variables to mark predefined catchment level values.

  

  donaldwj

  authored and

  mattw-nws

  committed
  ae1f8a9

  Copy full SHA for ae1f8a9

• Add missing config file for a multilevel configuration testing.

  

  donaldwj

  authored and

  mattw-nws

  committed
  32bb806

  Copy full SHA for 32bb806

• Updated level variables in multilevel hydrofabric test to match documentation.

  

  donaldwj

  authored and

  mattw-nws

  committed
  88434af

  Copy full SHA for 88434af

• Update non mpi code to handle hydro fabric multiple levels. Fix bug where level was not a string.

  

  donaldwj

  authored and

  mattw-nws

  committed
  758898f

  Copy full SHA for 758898f

• Add support for hydrofabric levels.

  

  donaldwj

  authored and

  mattw-nws

  committed
  6f6413e

  Copy full SHA for 6f6413e

• Added runtime loop based on levels.

  

  donaldwj

  authored and

  mattw-nws

  committed
  6eb6398

  Copy full SHA for 6eb6398

• saving for merge

  

  donaldwj

  authored and

  mattw-nws

  committed
  f212291

  Copy full SHA for f212291

• Fix for error in rebase.

  

  donaldwj

  authored and

  mattw-nws

  committed
  c813e1e

  Copy full SHA for c813e1e

• Fix missing variable in HY_Features.hpp

  

  donaldwj

  authored and

  mattw-nws

  committed
  79665b9

  Copy full SHA for 79665b9

• added test file using google test replacing stand alone test.

  

  donaldwj

  authored and

  mattw-nws

  committed
  b82da39

  Copy full SHA for b82da39

• fix parsing of layer data from the formulation config file.

  

  donaldwj

  authored and

  mattw-nws

  committed
  29216b7

  Copy full SHA for 29216b7

• Update test code for multilayer.

  

  donaldwj

  authored and

  mattw-nws

  committed
  dbf2b27

  Copy full SHA for dbf2b27

• Multilayer test added to CMake.

  

  donaldwj

  authored and

  mattw-nws

  committed
  652e5ec

  Copy full SHA for 652e5ec

• Add datastructures for storing layer meta data and add those structures to the formulation manager.

  

  donaldwj

  authored and

  mattw-nws

  committed
  922e3c5

  Copy full SHA for 922e3c5

• Inital multi time step muti level time loop

  

  donaldwj

  authored and

  mattw-nws

  committed
  42e0a5e

  Copy full SHA for 42e0a5e

• Simulation_Time methods useful for multilayer

  

  Matt Williamson

  authored and

  mattw-nws

  committed
  bb95a5a

  Copy full SHA for bb95a5a

• Change get_properties() of the FeatureBase class to return const or normal references to avoid copies of maps

  

  donaldwj

  authored and

  mattw-nws

  committed
  f1d0628

  Copy full SHA for f1d0628

• add an internal map to the network class to track layer association.

  

  donaldwj

  authored and

  mattw-nws

  committed
  605810a

  Copy full SHA for 605810a

• Add support for filtering a network based on level.

  

  donaldwj

  authored and

  mattw-nws

  committed
  e1881ef

  Copy full SHA for e1881ef

• Create inital skelton of layer class.

  

  donaldwj

  authored and

  mattw-nws

  committed
  6c623cb

  Copy full SHA for 6c623cb

• add <string> to simulation_time.hpp to fix VSCode issue

  

  donaldwj

  authored and

  mattw-nws

  committed
  01539c5

  Copy full SHA for 01539c5

• Add missing changes to Layer.hpp

  

  donaldwj

  authored and

  mattw-nws

  committed
  563fa87

  Copy full SHA for 563fa87

• moved logic to run catchments into layer class

  

  donaldwj

  authored and

  mattw-nws

  committed
  726fc4e

  Copy full SHA for 726fc4e

• remove code that is no longer needed

  

  donaldwj

  authored and

  mattw-nws

  committed
  7b1ed93

  Copy full SHA for 7b1ed93

• Fix typos

  

  donaldwj

  authored and

  mattw-nws

  committed
  2d067fa

  Copy full SHA for 2d067fa

• update layer control for better depnd btwn layers

  

  donaldwj

  authored and

  mattw-nws

  committed
  062586d

  Copy full SHA for 062586d

• Add command to advance the current time stored in a layer.

  

  donaldwj

  authored and

  mattw-nws

  committed
  2867f03

  Copy full SHA for 2867f03

• add current_timestep_epoch_time to layers

  

  donaldwj

  authored and

  mattw-nws

  committed
  1c892bf

  Copy full SHA for 1c892bf

• commit changes to simulation time object to allow current time update.

  

  donaldwj

  authored and

  mattw-nws

  committed
  e119816

  Copy full SHA for e119816

• Fix to missing changes on pervious commit.

  

  donaldwj

  authored and

  mattw-nws

  committed
  3f0299e

  Copy full SHA for 3f0299e

• Updates to fix testing on Multilayer

  

  donaldwj

  authored and

  mattw-nws

  committed
  b16bb3b

  Copy full SHA for b16bb3b

• Add current_time_index to SurfaceLayer to

  Show description for dc7b05f
  

  donaldwj

  authored and

  mattw-nws

  committed
  dc7b05f

  Copy full SHA for dc7b05f

• Added more documentation to main time loop.

  Show description for e7bcd87
  

  donaldwj

  authored and

  mattw-nws

  committed
  e7bcd87

  Copy full SHA for e7bcd87

• Fix to HY_Features constructor

  Show description for 9c00898
  

  donaldwj

  authored and

  mattw-nws

  committed
  9c00898

  Copy full SHA for 9c00898

• Add defualt layer creation to formulation manager

  

  donaldwj

  authored and

  mattw-nws

  committed
  96fdee2

  Copy full SHA for 96fdee2

• fix bad units on defualt layer

  

  donaldwj

  authored and

  mattw-nws

  committed
  c9fe2d6

  Copy full SHA for c9fe2d6

• Correct units string for default layer.

  

  donaldwj

  authored and

  mattw-nws

  committed
  1cb583e

  Copy full SHA for 1cb583e

• Fix merge error in HH_Features_MPI.hpp

  

  donaldwj

  authored and

  mattw-nws

  committed
  52d02b8

  Copy full SHA for 52d02b8

• Required fixes for serial build

  mattw-nws

  committed
  acdd022

  Copy full SHA for acdd022

Commits on Jul 14, 2023

• Create HY_Catchments with level metadata in single processor mode.

  donaldwj

  committed
  b64af75

  Copy full SHA for b64af75

• Change HY_Features constructor to use the link hydrofabric version that works with levels.

  donaldwj

  committed
  22a7c93

  Copy full SHA for 22a7c93

Commits on Aug 3, 2023

• Resolving issues from pr review.

  donaldwj

  committed
  ee1577e

  Copy full SHA for ee1577e

Commits on Aug 23, 2023

• Correct typedef to ussing change that was not finished.

  donaldwj

  committed
  6803778

  Copy full SHA for 6803778

• Correct primary time loop time objects was not being advanced.

  donaldwj

  committed
  5953311

  Copy full SHA for 5953311

• More corrections to time object advancment.

  donaldwj

  committed
  b25be4b

  Copy full SHA for b25be4b

• Remove debuging code.

  donaldwj

  committed
  49f559a

  Copy full SHA for 49f559a