Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole SFA/MF buildings: shared boilers #1599

Closed
wants to merge 16 commits into from

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jan 27, 2024

Pull Request Description

Addresses #1499.

Allows:

  • One or more shared boilers serving multiple dwelling units of a whole SFA/MF building
  • User-specified boiler operation (sequenced vs simultaneous)
  • User-specified supply/return temperatures
  • ???

Should wait on hpxmlwg/hpxml#399 before merging?

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Jan 27, 2024
…erties of the sameas obj, we'll just provide a simple means to getting that obj.
@shorowit shorowit added the enhancement New feature or request label Feb 1, 2024
shorowit and others added 11 commits February 6, 2024 10:04
…o whole_mf_building_shared_boilers

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
…o whole_mf_building_shared_boilers

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	ReportSimulationOutput/measure.xml
#	tasks.rb
#	workflow/hpxml_inputs.json
shorowit and others added 3 commits March 15, 2024 13:31
…o whole_mf_building_shared_boilers

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.rb
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hpxml_defaults.rb
#	HPXMLtoOpenStudio/resources/hvac_sizing.rb
#	ReportSimulationOutput/measure.xml
#	tasks.rb
#	workflow/tests/base_results/results_workflow_simulations1.csv
#	workflow/tests/base_results/results_workflow_simulations1_bills.csv
@shorowit shorowit added this to the 1.9.0 milestone Mar 25, 2024
@shorowit shorowit removed this from the 1.9.0 milestone Sep 6, 2024
@shorowit
Copy link
Contributor Author

Replaced by #1893

@shorowit shorowit closed this Nov 26, 2024
@shorowit shorowit deleted the whole_mf_building_shared_boilers branch November 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority medium
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant