Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug license header check [skip ci] #2616

Merged
merged 15 commits into from
Nov 21, 2024
Merged

Fix bug license header check [skip ci] #2616

merged 15 commits into from
Nov 21, 2024

Conversation

YanxuanLiu
Copy link
Collaborator

@YanxuanLiu YanxuanLiu commented Nov 21, 2024 •
edited
Loading

part fix of #2614

  1. set dynamic checkout depth to avoid missing target commit id.
  2. skip action for auto merge PRs.
  3. excludes thirdparty/*

YanxuanLiu and others added 9 commits November 21, 2024 11:33
@YanxuanLiu
add excludes, skip for special pr
09d309f 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
change depth
1ac9254 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
dynamic depth
8fe254c 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
depth
56db8c3 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
test
01b099f 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
test
b4dd1fd 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
test
66f5706 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
+10 depth
9fd050a 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
remove useless changes
a818d6e
@YanxuanLiu YanxuanLiu requested a review from pxLi November 21, 2024 04:24
@YanxuanLiu YanxuanLiu self-assigned this Nov 21, 2024
@YanxuanLiu YanxuanLiu marked this pull request as ready for review November 21, 2024 04:24
@pxLi pxLi changed the title Fix bug license header check Fix bug license header check [skip ci] Nov 21, 2024
pxLi
pxLi previously approved these changes Nov 21, 2024
View reviewed changes
@pxLi pxLi dismissed their stale review November 21, 2024 04:28

one nit

pxLi
pxLi reviewed Nov 21, 2024
View reviewed changes
.github/workflows/license-header-check.yml Outdated
@@ -22,11 +22,16 @@ on:
jobs:
license-header-check:
runs-on: ubuntu-latest
if: "!startsWith(${{github.event.pull_request.title}}, '[submodule-sync]')"
Copy link
Collaborator

@pxLi pxLi Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: format if: "!startsWith(github.event.pull_request.title, '[submodule-sync]')"

@pxLi pxLi added the bug Something isn't working label Nov 21, 2024
@YanxuanLiu
check title contains bot
5203ddf 
Signed-off-by: YanxuanLiu <[email protected]>
pxLi
pxLi previously approved these changes Nov 21, 2024
View reviewed changes
@YanxuanLiu
contains issueg
3aaf553 
Signed-off-by: YanxuanLiu <[email protected]>
@pxLi pxLi dismissed their stale review November 21, 2024 04:50

invalid if express

@pxLi
Copy link
Collaborator

pxLi commented Nov 21, 2024

build

@YanxuanLiu YanxuanLiu merged commit 63f417a into NVIDIA:branch-24.12 Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxLi pxLi pxLi approved these changes

Assignees

@YanxuanLiu YanxuanLiu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YanxuanLiu @pxLi