Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug license header check [skip ci] #2616

Merged
merged 15 commits into from
Nov 21, 2024
Merged

Fix bug license header check [skip ci] #2616

Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
09d309f
add excludes, skip for special pr
YanxuanLiu Nov 21, 2024
1ac9254
change depth
YanxuanLiu Nov 21, 2024
8fe254c
dynamic depth
YanxuanLiu Nov 21, 2024
56db8c3
depth
YanxuanLiu Nov 21, 2024
01b099f
test
YanxuanLiu Nov 21, 2024
b4dd1fd
test
YanxuanLiu Nov 21, 2024
66f5706
test
YanxuanLiu Nov 21, 2024
9fd050a
+10 depth
YanxuanLiu Nov 21, 2024
a818d6e
remove useless changes
YanxuanLiu Nov 21, 2024
3a70db9
remove space line
YanxuanLiu Nov 21, 2024
5138a78
Update license-header-check.yml
YanxuanLiu Nov 21, 2024
67f3306
Update license-header-check.yml format
YanxuanLiu Nov 21, 2024
9826d73
Merge branch 'fix-bug_license-header-check' of https://github.com/Yan…
YanxuanLiu Nov 21, 2024
5203ddf
check title contains bot
YanxuanLiu Nov 21, 2024
3aaf553
contains issueg
YanxuanLiu Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/license-header-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,16 @@ on:
jobs:
license-header-check:
runs-on: ubuntu-latest
if: "!startsWith(${{github.event.pull_request.title}}, '[submodule-sync]')"
Copy link
Collaborator

@pxLi pxLi Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: format if: "!startsWith(github.event.pull_request.title, '[submodule-sync]')"

steps:
- name: Get checkout depth
run: |
echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 10 ))" >> $GITHUB_ENV

- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 5
fetch-depth: ${{ env.PR_FETCH_DEPTH }}

- name: license-header-check
uses: NVIDIA/spark-rapids-common/license-header-check@main
Expand All @@ -46,3 +51,5 @@ jobs:
*.xml,
*.fbs,
build/*
excluded_file_patterns: |
thirdparty/*
Loading