Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing, add more tests and make them run with Github actions #28

Merged
merged 22 commits into from
Jan 4, 2024

Conversation

aanil
Copy link
Member

@aanil aanil commented Jan 3, 2024

With the current setup, Github actions run the tests on every push and pull request.

Also moved STATUS_PRIORITY and STATUS_PRIORITY_REV to config

@aanil aanil added the no validation validation not needed label Jan 3, 2024
@aanil aanil requested a review from alneberg January 3, 2024 16:29
DAILY_READ_FETCH_FROM_NGIS = true
DAILY_READ_FETCH_FROM_SNPSEQ = true
DAILY_READ_FETCH_FROM_UGC = true
#DAILY_READ_LOG_LOCATION='tests/log_location'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to keep this comment here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe as a reminder for future tests? I can get rid of it too.

Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to keep developing the tests!

@aanil aanil merged commit be38851 into NationalGenomicsInfrastructure:main Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no validation validation not needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants