Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme: first draft, log error instead of raising exception on failed upload, cleanup tests a bit #33

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

aanil
Copy link
Member

@aanil aanil commented Jan 19, 2024

No description provided.

@aanil aanil added the no validation validation not needed label Jan 19, 2024
@aanil aanil requested a review from alneberg January 19, 2024 12:48
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f40b7cb) 75.78% compared to head (9336881) 75.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
daily_read/__main__.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   75.78%   75.33%   -0.45%     
==========================================
  Files           8        8              
  Lines         512      519       +7     
==========================================
+ Hits          388      391       +3     
- Misses        124      128       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

@aanil aanil merged commit 913ae31 into NationalGenomicsInfrastructure:main Jan 19, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no validation validation not needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants