Filter None from report, catch all possible exceptions during upload and do not stage the project #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and do not stage the project
alneberg
reviewed
Jan 26, 2024
alneberg
reviewed
Jan 26, 2024
daily_read/__main__.py
Outdated
| op.projects_data.stage_data_for_project(project) | ||
| # catch any and every exception during upload | ||
| except Exception as e: | ||
| log.error(f"Theres was an issue in uploading/hiding reports for {project.project_id}: {e}") |
There was a problem hiding this comment.
Maybe make this error message more threatening. "Exception raised" and "Still continuing with other reports" and similar phrases could be used.
There was a problem hiding this comment.
Made it a bit more threatening 😄
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 75.33% 75.52% +0.19%
==========================================
Files 8 8
Lines 519 519
==========================================
+ Hits 391 392 +1
+ Misses 128 127 -1 ☔ View full report in Codecov by Sentry. |
aanil
merged commit 5ef79ea
into
NationalGenomicsInfrastructure:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.