Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the handling of directory paths in the
SS3Sample
class and related methods, moving the responsibility to theSampleFileHandler
class. The most important changes include renamingbase_dir
toproject_dir
, removing theproject_dir
andsample_dir
attributes fromSS3Sample
and updating methods to useSampleFileHandler
for directory paths.Refactoring directory path handling:
lib/realms/smartseq3/ss3_sample.py
: Removedproject_dir
andsample_dir
attributes fromSS3Sample
and updated methods to useSampleFileHandler
for directory paths. [1] [2] [3] [4]lib/realms/smartseq3/utils/sample_file_handler.py
: UpdatedSampleFileHandler
to initializeproject_dir
andsample_dir
based onsample.project_info
and refactored methods to use these attributes. [1] [2]