Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Report Transfer utilities [used in 10x for now] #13

Merged

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Nov 12, 2024

This pull request introduces a new report transfer feature and refactors the run_sample and sample_file_handler modules to support this functionality. The changes include adding a new utility function for transferring reports, updating the sample processing workflow, and enhancing the file handling capabilities.

New Features:

  • Report Transfer Functionality:
    • Added a new function transfer_report in lib/module_utils/report_transfer.py to handle the transfer of reports using rsync.
    • Integrated transfer_report into the post_process method of run_sample to transfer reports after processing.

Refactoring and Enhancements:

  • Run Sample Module:

    • Moved the initialization of SampleFileHandler to a later point in the constructor of run_sample.py to ensure proper setup. [1] [2]
    • Added logging for missing pipeline information in the process method to handle errors gracefully.
    • Updated the pre_process method to include additional logging paths.
  • Sample File Handler Module:

    • Enhanced SampleFileHandler to track pipeline information and manage report paths. [1] [2]
    • Added methods check_run_success and extract_report_path to verify the success of the run and extract report paths from output logs.

@glrs glrs merged commit 7dd3897 into NationalGenomicsInfrastructure:main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant