Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rsync command to account for non-existed parent folders in dest #14

Merged

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Nov 12, 2024

This pull request includes changes to the transfer_report function in lib/module_utils/report_transfer.py to improve the handling of remote directory paths and enhance logging.

Improvements to remote directory handling:

  • Refactored the construction of remote_dir to ensure it includes sample_id if provided.
  • Modified the rsync_command to include a --rsync-path option that creates the remote directory if it does not exist.

Enhancements to logging:

  • Added a debug log statement to output the constructed rsync_command for easier troubleshooting.

@glrs glrs merged commit 8536a79 into NationalGenomicsInfrastructure:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant