Update to interact with YggDB and follow AbstractProject changes #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
lib/realms/smartseq3
module, focusing on improving the initialization process and database interactions for theSS3Project
andSS3Sample
classes. The most important changes include reordering imports, updating method names, adding database initialization and sample addition steps, and ensuring the project ID is always available.Improvements to initialization and database interactions:
lib/realms/smartseq3/ss3_project.py
: Reordered imports to follow standard conventions.lib/realms/smartseq3/ss3_project.py
: Updated the__init__
method to callsuper().__init__
and renamed_check_required_fields
tocheck_required_fields
. Added a call toinitialize_project_in_db
if the required fields are present.lib/realms/smartseq3/ss3_project.py
: Added a call toadd_samples_to_project_in_db
in thelaunch
method to ensure samples are added to the database before processing.lib/realms/smartseq3/ss3_project.py
: Updated theextract_samples
method to passyggdrasil_db_manager
to theSS3Sample
constructor.Enhancements to
SS3Sample
class:lib/realms/smartseq3/ss3_sample.py
: Modified the__init__
method to acceptyggdrasil_db_manager
and ensureproject_id
is always available. [1] [2] [3]lib/realms/smartseq3/ss3_sample.py
: Updated thestatus
setter to update the sample status in the database.