Refactor/project name formatting #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the project information extraction and directory creation logic in the
smartseq3andtenxrealms. More specifically, we used to replace "." in the project name with "__". With this PR this won't happen anymore.Changes to project information extraction:
lib/realms/smartseq3/smartseq3.py: Removed the replacement of dots with double underscores in theproject_namefield in the_extract_project_infomethod.lib/realms/tenx/tenx_project.py: Removed the replacement of dots with double underscores in theproject_namefield in the_extract_project_infomethod.Changes to directory creation:
lib/realms/tenx/tenx_project.py: Updated theensure_project_directorymethod to create the project directory under a "projects" subdirectory within the base directory specified by the10x_dirconfiguration.