-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDB IGNORE] [MDB IGNORE] HUD datum cleanup. #3114
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
work in progress
This PR is under development and shouldn't be merged.
❄️frozen❄️
Do not merge until the dev freeze is over.
labels
Jun 11, 2023
MistakeNot4892
force-pushed
the
hud
branch
4 times, most recently
from
June 13, 2023 12:22
15d9dbd
to
786406b
Compare
MistakeNot4892
changed the title
HUD datum cleanup.
[IDB IGNORE] [MDB IGNORE] HUD datum cleanup.
Jun 13, 2023
MistakeNot4892
force-pushed
the
hud
branch
5 times, most recently
from
June 17, 2023 14:17
d6ff500
to
675a62c
Compare
MistakeNot4892
force-pushed
the
hud
branch
2 times, most recently
from
June 27, 2023 07:33
3762ae6
to
cbee317
Compare
MistakeNot4892
added
the
stale
One week from the time of labelling, this PR will be closed as inactive.
label
Nov 2, 2023
Closing as stale, big chunks have been picked out to other PRs anyway. |
MistakeNot4892
added
the
legitimate salvage
This PR was closed without merge, but is desirable.
label
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
legitimate salvage
This PR was closed without merge, but is desirable.
stale
One week from the time of labelling, this PR will be closed as inactive.
work in progress
This PR is under development and shouldn't be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Collapses HUD icons and icon updates onto
/datum/hud
where possible.Adds a helper (
/mob/proc/get_target_zone()
) to replace using the zone selector screen element directly.Oh god it spiralled out of control.
TODO:
Why and what will this PR improve
The current HUD code duplicates a ton of logic and element creation. This should make it much easier to handle HUDs in general.
Authorship
Myself.
Changelog
Ideally, nothing player facing.