Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDB IGNORE] [MDB IGNORE] HUD datum cleanup. #3114

Closed
wants to merge 32 commits into from

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Jun 11, 2023

Description of changes

Collapses HUD icons and icon updates onto /datum/hud where possible.
Adds a helper (/mob/proc/get_target_zone()) to replace using the zone selector screen element directly.
Oh god it spiralled out of control.

TODO:

  • Uncomment/implement the periodic HUD icon updates using the commented code.
  • Split the construct icons up into several sets.
  • Update existing hud types to use the correct elements.
  • Work out the ordering issue with alerts/element updates.
  • Go back over Life() and check if reordering the parent calls has cooked anything.
  • Test that everything is placed properly and functions as expected.

Why and what will this PR improve

The current HUD code duplicates a ton of logic and element creation. This should make it much easier to handle HUDs in general.

Authorship

Myself.

Changelog

Ideally, nothing player facing.

@MistakeNot4892 MistakeNot4892 added work in progress This PR is under development and shouldn't be merged. ❄️frozen❄️ Do not merge until the dev freeze is over. labels Jun 11, 2023
@MistakeNot4892 MistakeNot4892 force-pushed the hud branch 4 times, most recently from 15d9dbd to 786406b Compare June 13, 2023 12:22
@MistakeNot4892 MistakeNot4892 changed the title HUD datum cleanup. [IDB IGNORE] [MDB IGNORE] HUD datum cleanup. Jun 13, 2023
@MistakeNot4892 MistakeNot4892 force-pushed the hud branch 5 times, most recently from d6ff500 to 675a62c Compare June 17, 2023 14:17
@MistakeNot4892 MistakeNot4892 removed the ❄️frozen❄️ Do not merge until the dev freeze is over. label Jun 22, 2023
@MistakeNot4892 MistakeNot4892 force-pushed the hud branch 2 times, most recently from 3762ae6 to cbee317 Compare June 27, 2023 07:33
@MistakeNot4892 MistakeNot4892 added the stale One week from the time of labelling, this PR will be closed as inactive. label Nov 2, 2023
@MistakeNot4892
Copy link
Contributor Author

Closing as stale, big chunks have been picked out to other PRs anyway.

@MistakeNot4892 MistakeNot4892 deleted the hud branch February 11, 2024 11:24
@MistakeNot4892 MistakeNot4892 added the legitimate salvage This PR was closed without merge, but is desirable. label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legitimate salvage This PR was closed without merge, but is desirable. stale One week from the time of labelling, this PR will be closed as inactive. work in progress This PR is under development and shouldn't be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant