Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print base rings terse and starting with lowercase #1680

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin
Copy link
Member Author

There are still some uses of compact left but they all seem to be related to printing vectors or elements of a matrix, so I am not sure if they should be kept at compact or changed to supercompact ` terse ... E.g.:

function show(io::IO, v::SNFModuleElem)
   print(io, "(")
   len = ngens(parent(v))
   for i = 1:len - 1
      print(IOContext(io, :compact => true), v.v[1, i])
      print(io, ", ")
   end
   if len > 0
      print(IOContext(io, :compact => true), v.v[1, len])
   end
   print(io, ")")
end

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.97%. Comparing base (ac34f40) to head (a6e92a4).
Report is 1 commits behind head on master.

Files Patch % Lines
src/generic/Misc/Localization.jl 0.00% 3 Missing ⚠️
src/generic/SparsePoly.jl 0.00% 2 Missing ⚠️
src/generic/InvariantFactorDecomposition.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1680   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         116      116           
  Lines       29610    29610           
=======================================
+ Hits        25752    25753    +1     
+ Misses       3858     3857    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator

The failure https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/8816772846/job/24201674662?pr=1680#step:7:3437 looks unexpected.

Parent object call overloading: Test Failed at /home/runner/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Nemo/test/HeckeMiscLocalization-test.jl:78
  Expression: L1(L2(5))
    Expected: ErrorException
      Thrown: MethodError
Stacktrace:
 [1] macro expansion
   @ ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/oscar-dev/Nemo/test/HeckeMiscLocalization-test.jl:78 [inlined]

I'll look into this

@lgoettgens
Copy link
Collaborator

Furthermore, there is a casing change for the word Singular happening in the downstream tests. This should be looked at (and maybe add a LowercaseOff) when updating Singular.jl to AA 0.41

│ Evaluated output:
│ 
│ Builder for an element of singular letterplace Ring (QQ),(x,y,z,x,y,z,x,y,z,x,y,z,x,y,z,x,y,z),(dp(18),C,L(3))
│ 
│ Expected output:
│ 
│ Builder for an element of Singular letterplace Ring (QQ),(x,y,z,x,y,z,x,y,z,x,y,z,x,y,z,x,y,z),(dp(18),C,L(3))

@lgoettgens
Copy link
Collaborator

There are still some uses of compact left but they all seem to be related to printing vectors or elements of a matrix, so I am not sure if they should be kept at compact or changed to supercompact ` terse ... E.g.:

Most of them seem to be AA MatElems. But element types don't have the three types of printing anyway. So no idea...

@fingolfin fingolfin force-pushed the mh/compact-to-terse branch from d26b5d0 to a6e92a4 Compare April 25, 2024 12:09
@fingolfin
Copy link
Member Author

The singular letterplace Ring vs Singular letterplace Ring is due to Singular.jl not using pretty printing at all so far. I've filed oscar-system/Singular.jl#798 as a reminder.

Otherwise I hope this PR is now ready to go

@lgoettgens lgoettgens enabled auto-merge (squash) April 25, 2024 12:22
@lgoettgens lgoettgens merged commit 1928f12 into master Apr 25, 2024
30 of 31 checks passed
@lgoettgens lgoettgens deleted the mh/compact-to-terse branch April 25, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants