-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print base rings terse and starting with lowercase #1680
Conversation
There are still some uses of function show(io::IO, v::SNFModuleElem)
print(io, "(")
len = ngens(parent(v))
for i = 1:len - 1
print(IOContext(io, :compact => true), v.v[1, i])
print(io, ", ")
end
if len > 0
print(IOContext(io, :compact => true), v.v[1, len])
end
print(io, ")")
end |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1680 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 116 116
Lines 29610 29610
=======================================
+ Hits 25752 25753 +1
+ Misses 3858 3857 -1 ☔ View full report in Codecov by Sentry. |
7e4ea78
to
d26b5d0
Compare
The failure https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/8816772846/job/24201674662?pr=1680#step:7:3437 looks unexpected.
I'll look into this |
Furthermore, there is a casing change for the word
|
Most of them seem to be AA |
d26b5d0
to
a6e92a4
Compare
The Otherwise I hope this PR is now ready to go |
No description provided.