Update Docker Actions and Support build-args
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional `dockerfile` input for non-default dockerfiles Add optional `build_args` input to support Docker build-args Add caching to Docker builds
NeonDaniel
force-pushed
the
FEAT_BetterDockerSupport
branch
from
d97a818 to
70c7cff
Compare
mikejgray
approved these changes
Dec 21, 2023
Just pulled the images from https://github.com/NeonDaniel/neon-iris/actions/workflows/publish_test_build.yml and they appear to have built with the expected dependencies/tags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update GHA versions to latest releases
Add optional
dockerfileinput for non-default dockerfilesAdd optional
build_argsinput to support Docker build-argsAdd caching to Docker builds
Issues
Closes #59
Other Notes
NeonGeckoCom/neon-iris#51 should be updated to use this shared action
Testing: https://github.com/NeonDaniel/neon-iris/actions/workflows/publish_test_build.yml